Skip to content
This repository has been archived by the owner on Nov 13, 2024. It is now read-only.

[Feature] Update dependency to support Pydantic > 2.0.0 #260

Closed
2 tasks done
InbarShirizly opened this issue Jan 22, 2024 · 1 comment · Fixed by #288
Closed
2 tasks done

[Feature] Update dependency to support Pydantic > 2.0.0 #260

InbarShirizly opened this issue Jan 22, 2024 · 1 comment · Fixed by #288
Labels
enhancement New feature or request

Comments

@InbarShirizly
Copy link

Is this your first time submitting a feature request?

  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing functionality

Describe the feature

Currently cannopy pydantic version in poetry is : pydantic = "^1.10.7"
When we want to work with applications using pydantic 2 -> it makes it very hard to work with the product and forces downgrades in other libraries

Describe alternatives you've considered

We are using now pydnatic 1 in our application, which cost us refactoring

Who will this benefit?

every user trying to add canopy to a poetry project that contains requirement for updated pydantic

Are you interested in contributing this feature?

No response

Anything else?

No response

@InbarShirizly InbarShirizly added the enhancement New feature or request label Jan 22, 2024
@igiloh-pinecone
Copy link
Contributor

Hi @InbarShirizly,

This is a tough one, since there are other users who are in the exact opposite position - their existing production code is already using pydantic 1.x.x, and a hard requirement for >2.0.0 might be breaking for them.
In addition, some of the underlying dependencies that Canopy uses still support pydantic 1 only.

We will look into this, and see if there's an easy way to support both needs, without too many hassle for users.

@izellevy izellevy linked a pull request Feb 12, 2024 that will close this issue
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants