You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In a codebase where developers manually execute the Plank binary to generate models, it is difficult to detect scenarios where they may be landing code based on an outdated Plank binary.
One possible solution would be to write a Plank version/build number of some kind into the generated model header block so that version control systems (e.g. Git, SVN) can warn developers with merge errors. e.g.
// Autogenerated by Plank (https://pinterest.github.io/plank/)
// Plank v7.32
The text was updated successfully, but these errors were encountered:
RicoYao
changed the title
Make it easier to detect merge conflicts in generated models
Make it easier to detect use of outdated Plank binary
Aug 23, 2019
@RicoYao - you can add the version to the generated code, in practice we end up updating the models when there is a new version of plank added to our repository
Just confirming what you mean by this - are you suggesting that we configure our own scripts to add the version header after Plank generates the models? We can do that.
I'm just saying that plank can update the file header it generates to output the current version. We have a struct that contains the version that you should be able to utilize
In a codebase where developers manually execute the Plank binary to generate models, it is difficult to detect scenarios where they may be landing code based on an outdated Plank binary.
One possible solution would be to write a Plank version/build number of some kind into the generated model header block so that version control systems (e.g. Git, SVN) can warn developers with merge errors. e.g.
The text was updated successfully, but these errors were encountered: