Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tab is not opened with expected position and container, when it is opened with either + or Cntl T #3291

Open
infonut opened this issue Feb 10, 2023 · 9 comments

Comments

@infonut
Copy link

infonut commented Feb 10, 2023

  1. I am not a programmer nor a computer person so could not start Firefox with clean profile - sorry!
  2. Installed TST on Feb 9, 2023 (version 3.9.12)
  3. Whether I disable all extensions or keep them all open except New Tab Override (keep disabled) the same result happens - so I assume it is not another extension.

## Expected result

  1. Option: New Tabs not from Existing Tabs
  2. Open New Blank Tab as:
    --The next sibling of the current tab
    *FYI: Actual Result (below) happens whether or not I click
    Treetab1
    --see "Here is the option" in word doc, attached

## Actual result
The response is intermittent, to say,

  1. I click cntl-T or click the “+” on the Firefox toobar 3 times in a row (and do nothing else in between) while on THE SAME root tab in the TST sidebar.
  2. The first 2 times I get 2 new tabs listed 1 below the other (with the black New Tab symbol) as a sibling to the root tab -as expected..
  3. The 3rd time I click it, the same exact command, I get the New Tab with the FF symbol that is at the
    bottom of the whole TST sidebar. (This is expected FF behavior but not the option chosen in TST)

image
--see attached word doc

  1. This intermittent behavior is repeated when clicking a new tab off a root tab for other various root tabs (not copied). Once, I did 4 root tabs in a row and got siblings as expected (as per Incorrect sidebar width after resizing and then switching windows #2, above), then the 5th tab went unexpectedly to the bottom, and when I went back to the tabs I had gone off before they now also showed up at the bottom vs directly below as in Incorrect sidebar width after resizing and then switching windows #2, which they had just done.
  2. So. Intermittent.

Environment

  • Platform (OS): Windows 10 Home
  • Version of Firefox: 109.0.1 (64-bit)
  • Version (or revision) of Tree Style Tab: 3.9.12

Qs Tree Style Tabs.zip

I hope this is enough information for you. As I said, I don't have much computer knowlege. Please post below if you need more information.

Thank you!

@infonut
Copy link
Author

infonut commented Feb 10, 2023

Not sure how/why #4 says "Incorrect sidebar width after resizing and then switching windows " Wasn't there when I posted it.

@piroor
Copy link
Owner

piroor commented Feb 13, 2023

Confirmed. This happens when you click the "+" button in the tab bar too frequently.

@SHHSSH
Copy link

SHHSSH commented Feb 24, 2023

Please see - #3296

It may benefit you.
If you need any help with your sidebar width, add this to your userchrome.css

/* remove maximum/minimum width restriction of sidebar */
#sidebar-box {
max-width: none !important;
min-width: 0px !important;
}

@piroor
Copy link
Owner

piroor commented Jan 17, 2024

I've realized that when I open 3 new tabs with Ctrl-T two tabs have about:newtab URL but the last one has about:blank so TST failed to detect the third new tab as a new tab command tab. With the commit c72d94e and 912f551 now TST sees the title of the tab also, so new tab command tabs are now detected more certainly.

@jordanhoskins
Copy link

The issue persists on Firefox. I have my default new tab set to "blank page", but TST still sends all tabs to the end.

MacOS 14.2.1 (23C71)
Firefox 122.0 (64-bit)
TST 3.9.21

@panckreous
Copy link

I can't tell if my issue was caused by these recent commits or not, but I'm pretty sure it's the same issue, hence the comment vs a new issue. Apologies if I'm wrong.

I have my tab preferences set to create new tabs in the last position when I use command-T (browser.tabs.insertAfterCurrent false). When I disable the Tree Style Tab extension, this works as expected. When I enable the extension, it overrides this setting and always creates new tabs after the current tab. There's a moment when I see the tab created in the proper position, but then it's moved from the end to after the current tab.

Please let me know if this comment should be moved to its own issue or if I should provide more information. Thanks for all your hard word @piroor

@piroor
Copy link
Owner

piroor commented Mar 6, 2024

@panckreous TST's option to control where a new tab is opened at affects not only for the "+" button in the tab bar but Ctrl/Command-T shortcut also. Did you change the option?

@irvinm
Copy link
Contributor

irvinm commented Nov 9, 2024

@piroor anything more you want to do on this one? There hasn't been any updates in 8 months.

@piroor
Copy link
Owner

piroor commented Nov 11, 2024

@jordanhoskins @panckreous Does the problem still appear with the latest TST?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants