Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PROJECT_DOMAIN from .env sample. #31

Open
marcbria opened this issue May 10, 2021 · 0 comments
Open

Remove PROJECT_DOMAIN from .env sample. #31

marcbria opened this issue May 10, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@marcbria
Copy link
Collaborator

marcbria commented May 10, 2021 •
edited
Loading

The PROJECT_DOMAIN is an old variable that is useless right now.

Looking into ojs-pre-start, config files in /etc/apache2/conf.d (as ssl.conf and ojs.conf), Dockerfile and all of them use SERVERNAME... I grep the project and I can find any reference to this, so I think we can safely remove it.

If nobody is against, we need to be this variable from the .env sample file.
@marcbria marcbria added the enhancement New feature or request label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcbria