Resolver plugin not matching on page ranges

[kaitlinnewson]

Describe the bug
When using the Resolver plugin to resolve a URL to an article, the matching is not working when a page range is used.

To Reproduce
Steps to reproduce the behavior:

1. Find an appropriate article that has a page range, and note the volume, number, and page range
2. Open a URL for the Resolver plugin that should match to an article (where brackets at the end of the URL are volume/number/page or page range), e.g.: http://localhost:8000/index.php/publicknowledge/gateway/plugin/ResolverPlugin/vnp/1/2/71-98
3. Note that article does not resolve for page range

What application are you using?
OJS 3.3/3.4/main

Pull requests

• OJS 3.3: pkp/pkp-lib#10786 fix resolver plugin page range matching ojs#4586
• OJS 3.4: pkp/pkp-lib#10786 fix resolver plugin page range matching ojs#4587
• OJS main (includes minor 3.5 fixes as well): pkp/pkp-lib#10786 fix resolver plugin page range matching and update … ojs#4588

[kaitlinnewson]

Hi @asmecher, could you give the PRs above a quick review & merge if all looks good? I've also done a couple of fixes for the plugin to work in 3.5. Thanks!

[asmecher]

@kaitlinnewson, those look good -- but at the risk of punishing a good deed, a similar regexp appears in the JATS Template plugin (classes/ArticleFront.php in main, elsewhere in previous branches). At least for the main branch, I'd suggest syncing this change there.

[kaitlinnewson]

@asmecher I've done the PRs for the JATS template plugin and they are ready for review:

• main (includes formatting updates and testing for 3.5 compatibility): pkp/pkp-lib#10786 fix page regex and cleanup formatting jatsTemplate#69
• 3.4: pkp/pkp-lib#10786 fix page matching regex jatsTemplate#70
• 3.3: pkp/pkp-lib#10786 fix page matching regex jatsTemplate#71

[asmecher]

Thanks, @kaitlinnewson, I've merged all those!

[asmecher]

Thanks, @kaitlinnewson, both PRs merged re: the test fix; this should all be working now.