Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any roadmap for fitlins? #81

Open
yarikoptic opened this issue Oct 29, 2018 · 9 comments
Open

Any roadmap for fitlins? #81

yarikoptic opened this issue Oct 29, 2018 · 9 comments

Comments

@yarikoptic
Copy link
Contributor

Hi Everyone,

Now that Derivatives (BEP003) and Linear Models (BEP002) are getting into somewhat usable shape, I wonder what are the plans/schedule for the fitlins -- will it be developed soon to accommodate for all the changes in those BEPs or there is another module/framework in works to look at in attempt to make initial use of BEP002?

Cheers!

@effigies
Copy link
Collaborator

Hi Yarik,

We're just about finished with getting fMRIPrep Derivatives RC-compliant, and so the next thing to turn to is FitLins. I hope to smooth out any derivatives-related issues this week, and be working on models by next week.

@yarikoptic
Copy link
Contributor Author

Awesome! Thank you @effigies !

@yarikoptic
Copy link
Contributor Author

I guess the majority of the work is to be done within https://github.com/bids-standard/pybids/tree/master/bids/analysis ?

@effigies
Copy link
Collaborator

@fliem
Copy link

fliem commented Apr 1, 2019

Hi @effigies
is there a timeline for the next release?
Is there an example model-file that replicates SPM first level results and that works with the current master?
Thanks!

@effigies
Copy link
Collaborator

effigies commented Apr 1, 2019

Hi @fliem. I just looked at the merge log, and it looks like I should definitely cut a release ASAP. This week is super busy, so I can't promise anything before next week, but if you're comfortable installing from master, then please feel free.

For model files, I will check. Do you have an open dataset you're looking at, or would you be happy with any OpenNeuro dataset?

@fliem
Copy link

fliem commented Apr 1, 2019

Thanks @effigies.
I installed from master, but for using it for a real analysis, I'd prefer a released version (is there anything speaking against using fitlins for real projects at the moment?).
Any dataset would be fine. It seems that the model examples are outdated, but I have too little insight into the BEP002 development process.
Always happy to contribute if there is anything I can do (for instance examples or documentation...).

@effigies
Copy link
Collaborator

effigies commented Apr 1, 2019

The main problems for real analyses right now are:

  1. Second-level analyses (i.e., anything above run-level) do not take into account variance estimates, only beta contrasts.
  2. Poor reporting at the second-level.
  3. No F-contrasts.

And yes, contributions are always welcome. Which I guess a roadmap would be useful for. In particular, tests and documentation are basically missing, but what would interest you to contribute most?

Is bids-standard/bids-examples#130 where you've been looking for examples? If so, I'll prioritize rewriting those to the current specification today. BEP-002 is a pretty slow-moving target at the moment, but it's also not fully internally consistent, so I understand that it's pretty confusing. That might be a good flight activity for me, tomorrow...

@fliem
Copy link

fliem commented Apr 1, 2019

For our purpose, run-level analysis is all we need.
I could contribute to the documentation.
I didn't realize this PR existed, I only have looked at fitlin's models branch.
It would be great to validate a very simple run-level contrast created with fitlins agains the same contrast created with something established (like SPM).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants