Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer to Polyvariant #477

Closed
8 tasks done
majk-p opened this issue Apr 22, 2024 · 12 comments
Closed
8 tasks done

Transfer to Polyvariant #477

majk-p opened this issue Apr 22, 2024 · 12 comments
Labels
breaking Source or binary breaking change

Comments

@majk-p
Copy link
Member

majk-p commented Apr 22, 2024

TL;DR the sttp-oauth2 project will be transferred to https://github.com/polyvariant/

This issue is a followup to the discussion in sttp softwaremill/sttp#2110. It captures the steps we need to take to transfer the project.

Transfer plan

Once the transfer is done we'll proceed with the waiting PRs and issues.

Open questions

For repackaging, should we use org.polyvariant.sttp.oauth2 or just sttp.oauth2?

@majk-p majk-p added the breaking Source or binary breaking change label Apr 22, 2024
@majk-p
Copy link
Member Author

majk-p commented Apr 22, 2024

Let me know what you think @zstoychev @kubukoz

@kubukoz
Copy link
Member

kubukoz commented Apr 23, 2024

For repackaging, should we use org.polyvariant.sttp.oauth2 or just sttp.oauth2?

I don't think it's right to start with sttp., so either the first one or sttpoauth2, that'd be my vote

@paul-sweetman-ocado
Copy link

Hi, a bit of a detail, but could you please ensure all references to Ocado are removed from the source code and documentation (except mentioning Ocado as the original author), before the repository is made public under the polyvariant org, and before any artefacts are published. Thanks.

@majk-p
Copy link
Member Author

majk-p commented Apr 25, 2024

This should not be a problem, I can raise a rebranding PR first, make the last release under Ocado organization on Maven and then transfer. This should simplify migration, maybe we could even provide a scalafix rule for scala steward to automatically fix the imports 🤔

@majk-p majk-p pinned this issue Apr 25, 2024
@majk-p majk-p mentioned this issue Apr 25, 2024
@majk-p
Copy link
Member Author

majk-p commented Apr 26, 2024

Rebranding PR is ready #478

CC: @paul-sweetman-ocado @zstoychev

@majk-p
Copy link
Member Author

majk-p commented May 12, 2024

The repository has now been transferred to https://github.com/polyvariant/sttp-oauth2, the last version v0.18.0 has been published under Ocado organization to maven and now maven credentials are changed to the ones for Polyvariant.

The website has also been redeployed and is now published from https://sttp-oauth2.polyvariant.org

Last thing to do will be to publish v0.19.0 in the new maven org and we'll be closing this issue.

@adamw
Copy link

adamw commented May 14, 2024

Great to hear :) Thanks for anybody involved

majk-p added a commit to majk-p/scala-steward-repos that referenced this issue May 18, 2024
@majk-p
Copy link
Member Author

majk-p commented May 18, 2024

v.0.19.0 has just been published and should be available on maven. I think this concludes the transfer. Thanks to everyone involved!

@majk-p majk-p closed this as completed May 18, 2024
@mzuehlke
Copy link

mzuehlke commented May 18, 2024

Adding a artefact migration rule to Scala Steward would automatically open PRs.

https://github.com/scala-steward-org/scala-steward/blob/main/docs/artifact-migrations.md

But the would all fail because you changed the package names. But at least it would give a hint to all users.
If you want to be fancy you could create a Scalafix rule 😀

@majk-p
Copy link
Member Author

majk-p commented May 18, 2024

That would be neat! I considered that, but with my limited time available and ZIO support in queue I decided to deliver quickly. Hopefully the migration guide will be enough 😅

@mzuehlke
Copy link

@majk-p
Copy link
Member Author

majk-p commented May 25, 2024

Thank you @mzuehlke, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Source or binary breaking change
Projects
None yet
Development

No branches or pull requests

5 participants