Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bus interactions with no witness columns fail #2292

Open
georgwiese opened this issue Dec 30, 2024 · 0 comments
Open

Bus interactions with no witness columns fail #2292

georgwiese opened this issue Dec 30, 2024 · 0 comments

Comments

@georgwiese
Copy link
Collaborator

georgwiese commented Dec 30, 2024

Consider this ASM file:

// we don't need to specify an operation_id if we have a single operation
machine SingleOperation with
    degree: 8,
    latch: latch
{
    operation nothing;

    col fixed latch = [1]*;
    col witness w;
    w = w * w;
}

machine Main with degree: 8 {
    SingleOperation m;

    link => m.nothing();

    col witness w;
    w = w * w;
}

This currently fails:

$ cargo run pil test_data/asm/single_operation.asm -o output -f --linker-mode bus --prove-with mock
...
thread 'main' panicked at /Users/georg/coding/powdr/backend-utils/src/lib.rs:218:26:
Identity references no namespace: Constr::PhantomBusInteraction(1, [0]);

The issue is that we can't associate an identity to a PIL namespace if it doesn't reference a column.

I wouldn't expect this to happen in practice, but you could think of cases where this would happen: If you have a stateful machine (e.g. one that interacts with memory) and no arguments. But actually, if it interacts with memory, it would at least receive the current time step, so I'm not sure if this is worth fixing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant