Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Add antialiasing to relevant Primer Brand components #871

Open
seangolob opened this issue Dec 19, 2024 · 1 comment · May be fixed by #884
Open

[Feature request] Add antialiasing to relevant Primer Brand components #871

seangolob opened this issue Dec 19, 2024 · 1 comment · May be fixed by #884
Assignees
@rezrah

Comments

@seangolob
Copy link

Hello Primer Brand team!

I am looking to add anti-aliasing to marketing pages in Dotcom. I initially reached for a global approach but it is recommended to apply anti aliasing on a per component basis. This is because antialiasing has caused issues with the global nav and other UI elements.

Relevant comment: https://github.com/github/marketing-platform-services/issues/3788#issuecomment-2549132457

Could we add antialiasing to the components in the Primer Brand library?

I understand that there are a lot of Primer Brand components available and it could take awhile to update all of them. Here is a list of components that are used in the Flex Template that the SWP team is working on which could be used to drive priority.

  • SubNav
  • Breadcrumbs
  • Hero
  • Section Intro
  • Pillars
  • LogoSuite
  • Cards
  • Bento
  • Prose
  • River/RiverBreakout
  • Testimonials
  • Statistic
  • CTA Banner
  • FAQ

Some of these components use the Heading component which has anti aliasing on already.

CC @jesussandreas

I appreciate all of your help with the Flex Template over the past month or so. Thank you! ❤
@rezrah rezrah self-assigned this Jan 9, 2025
@rezrah rezrah linked a pull request Jan 9, 2025 that will close this issue
Open
9 tasks
@rezrah
Copy link
Collaborator

rezrah commented Jan 9, 2025

👋 Thanks for putting in this request.

A PR is open to apply additional font smoothing to various components: #884

@jesussandreas please check out the PR description where I've provided a breakdown of where we can't apply anti-aliasing. Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rezrah rezrah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add anti-aliasing to Text and other components primer/brand
2 participants
@seangolob @rezrah