Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track work on PeerID based blocking #41

Open
thattommyhall opened this issue Aug 22, 2022 · 1 comment
Open

Track work on PeerID based blocking #41

thattommyhall opened this issue Aug 22, 2022 · 1 comment
Assignees

Comments

@thattommyhall
Copy link
Contributor

thattommyhall commented Aug 22, 2022

We currently block using a NACL, this obviously only stops the nodes directly communicating, some future routing (esp if enabled by default) could make them able to communicate.

Confirmed for now that they cannot communicate with

# ipfs swarm connect /p2p/12D3KooWJj76d91UfktyF9CfR1HxmjuV8DVAXMGUPTBPn4iAATDg
Error: connect 12D3KooWJj76d91UfktyF9CfR1HxmjuV8DVAXMGUPTBPn4iAATDg failure: routing: not found

which uses all the routing methods available

@iand :

To do it properly we need ipfs/kubo#8867 which could be done soon if ipfs/kubo#9010 gets merged. The alternative route is via the proposed ipfs rules command which is not fully specified yet ipfs/kubo#8492

@iand
Copy link
Contributor

iand commented Oct 3, 2022

ipfs/kubo#8867 won't help us here. The libp2p changes only cover blocking of peers that are requesting blocks, whereas we want to prevent fetching from certain peers.

@iand iand self-assigned this Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants