Not working on Fedora 26 (GNOME 3.24.2) #198
Comments
|
I'm getting same error on Fedora 27 at Gnome 3.26. |
|
It is working with developers version of an extension: https://extensions.gnome.org/extension/1223/hamster-time-tracker/ |
|
Sooo..... :) If you feel up to it, please try the current |
elbenfreund
added
bug
|
Also, if it turns out that this is about the hamster-service not running, this is most likely a dupe of #159 |
|
I'm getting same error, but hamster-service seems to be running for me. Gnome 3.26.1. https://extensions.gnome.org/extension/1223/hamster-time-tracker/ seems to work fine though. |
|
Hello @nijel . Have you tested against the version on EGO or against |
|
Version on EGO, I can try develop as well (as soon as I figure out how to install it). |
|
It doesn't work for me: |
|
After applying patch in #207 it works. |
|
Ping? GNOME 3.26 is now in Debian unstable and it would be nice if users of the extension had a way to upgrade to a working version. |
|
BTW: The development version mostly works, but sometimes it crashes and when running on Wayland, it crashes whole GNOME session (on X server, it crashes "only" gnome shell which restarts). |
|
I've observed the same crashes. The workaround is to switch to X, but it's not ideal. |
|
@nijel @a-m-s If so I think it would be preferable to move towards closing this particular issue and open a new one specific to the crashes. @rhertzog |
|
@elbenfreund FWIW, I have been using the fork you linked to for a while and I got a crash with it as well (only once in 3 weeks of use). And it contains annoying changes that don't integrate well with the Debian package of hamster-time-tracker as the path for starting the services are different... (and really it's not the job of the extension to start services). |
|
@rhertzog Thanks for this valuable feedback. Just to be clear: you experience those crashes under wayland only (as the others)? |
|
@elbenfreund Well, I did not switch back to Xorg to verify that I don't get any crash under Xorg. But I assume the bug is present in both cases... except that crashing gnome-shell under Wayland crashes the session whereas crashing gnome-shell under Xorg only results in a gnome-shell restart, the session remains open. This is a design peculiarity of Wayland where the compositor owns the display and without display, there is no session whatsoever. |
|
@rhertzog Thanks for the clarification. Do you happen to have any logs/error msg at hand that could be of use tracking this down? |
|
Hum, I don't remember when I got the crash and it's likely before my last reboot so I might not have the logs. Still I found this error message. It occurs when I add a new entry through the extension. It's likely unrelated to the crash. |
|
For me the following seem to be related parts of the log to the crash: In the end it's gnome-shell which dies, what leads to end of session on Wayland while it is restarted with XOrg. |
|
outch.. that is very disheartening. If I understand correctly this seems to indicate an issue with |
|
If you have some ideas how to debug it, I'm happy to help. The crash usually happens to me several times daily. |
|
Can we do something to have a working hamster again? Here's the full log (in reverse order) I just got after a crash. It's also a segfault in gnome-shell in the end (see line with =>): |
|
@elbenfreund Ping ? I can currently reproduce it fairly easily. With error messages like above. I'm happy to try out patches and help debug this. It's really annoying me a lot. |
|
It annoyed me enough that I spent my afternoon on this... the result is in #217. It fixes the issues I was experiencing even though I was not expecting that fixing a simple warning was enough to solve this issue. Please merge my pull request and get a release out so that non-experienced users can have a working hamster time tracker too. FWIW the last remaining issue for me is #218. |
|
My sincere appologies @rhertzog for letting this slide so badly. I will deal with this over the weekend and provide feedback in order to merge the PR asap. Until then, please accept my utmost gratitude for your work towards bringing back the shell extension. |
elbenfreund
pushed a commit
that referenced
this issue
Mar 11, 2018
Removes extra arguments from function call. Otherwise one would get the following warning on startup: ``` JS WARNING: [/.../[email protected]/extension.js 132]: Too many arguments to function Gio.bus_watch_name: expected 5, got 6 ``` Ref.: #198 #205
elbenfreund
pushed a commit
that referenced
this issue
Mar 11, 2018
This is to fix this new gjs warning: ``` Some code accessed the property 'PanelWidget' on the module 'panelWidget'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway. ``` Ref.: #198 #205
elbenfreund
added a commit
that referenced
this issue
Mar 11, 2018
This merge is a direct copy of Raphaël Hertzog work (#217 ) with just minor (mostly markdown related) changes to commit messages. It does tree things: - Avoid creation of duplicated convinience.js files - Use ``var`` instead of ``const`` to export variables - Fix broken argument list for ``Gio.bus_watch_name()`` In effect this seems to fix several outstanding bugs. For the original PR message and further information please refer to #217 Ref.: #205 #198
|
To all parties interested in sorting this out, please feel encouraged to try the latest development branch and let us know how things are going for you! :) |
|
PR #239 has been merged in develop and we hope that htis may improve the situation. If you would be so kind as to give it a try...?! |
|
Just switched to it and it seems to work fine for me so far. I'll report back if I have any issue. But right now the delay I used to see is gone (but it was also gone the other day and then it reappeared). |
|
The delay to update data (aka #205) reappeared but I haven't had any crash so far. |
|
I would like to streamline our remaing "crash related" issue a bit. As far as I can tell, #159 and #198 have been addressed to the extend that was/is specific to wayland/fedora. The extension should be handling missing services better and a bunch of unrelated issues brought up in those issues has been cleared to. In order to deal with the remaining crashes, I suggest moving the conversation to #212, with regards to the delay in visual updates on the panel: #205 Does this work for you? Are there any open questinons that are specific to this particular issue title? |
elbenfreund
removed
the
waiting for feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bumping versions in
metadata.jsondoesn’t help in this case. The looking glass sys:There is also an error when I try opening the preferences dialog:
The text was updated successfully, but these errors were encountered: