cURL timeout resulting in failed recurring payment

[rvdsteege]

In internal Help Scout ticket https://secure.helpscout.net/conversation/2482719794/26765 it came to our attention that the status of a recurring payment can be set to Failure in WordPress, while the actual payment has been paid successfully.

The cause seems to be a cURL timeout on payment start, which is converted from WP_Error to an exception in the pronamic/wp-http library, resulting in the Failure payment status.

https://github.com/pronamic/wp-http/blob/2b0ce3ca663103b8a30101ff5bff9254ee4da093/src/Facades/Http.php#L37-L43

wp-pay-core/src/Plugin.php

Lines 1110 to 1125 in e484e55

	$gateway->start( $payment );
	} catch ( \Exception $exception ) {
	$message = $exception->getMessage();
	// Maybe include error code in message.
	$code = $exception->getCode();
	if ( $code > 0 ) {
	$message = \sprintf( '%s: %s', $code, $message );
	}
	$payment->add_note( $message );
	$payment->set_status( PaymentStatus::FAILURE );
	throw $exception;

[remcotolsma]

As discussed @pronamic HQ we may want to increase the WordPress HTTP API timeout when dealing with an "Action Scheduler" background task:

$args = [
	'method'     => $method,
	'user-agent' => $this->get_user_agent(),
	'headers'    => [
		'Authorization' => 'Bearer ' . $this->api_key,
	],
	'timeout'    => \wp_doing_cron() ? 30 : 5,
];

https://github.com/pronamic/wp-mollie/blob/19f65f82ea9ffd3cc9eb71412c5ae7bfd0a93525/src/Client.php#L113-L128

Let us wait a moment for a possible response to the following issue:

• Make it easier to determine if we are 'inside' a queue processor woocommerce/action-scheduler#1024

[remcotolsma]

Fixed with:

• wp-pay-core/src/ActionSchedulerController.php

  Lines 1 to 41 in b1c28b0

  	<?php
  	/**
  	* Action Scheduler Controller
  	*
  	* @author Pronamic <[email protected]>
  	* @copyright 2005-2023 Pronamic
  	* @license GPL-3.0-or-later
  	* @package Pronamic\WordPress\Pay
  	*/
  	namespace Pronamic\WordPress\Pay;
  	/**
  	* Action Scheduler Controller class
  	*/
  	class ActionSchedulerController {
  	/**
  	* Setup.
  	*
  	* @return void
  	*/
  	public function setup() {
  	\add_action( 'action_scheduler_begin_execute', [ $this, 'begin_execute' ], 10, 2 );
  	}
  	/**
  	* Action scheduler begin execute.
  	*
  	* @link https://github.com/woocommerce/action-scheduler/blob/3.7.1/classes/abstracts/ActionScheduler_Abstract_QueueRunner.php#L84
  	* @param int $action_id Action ID.
  	* @param string $context Context.
  	* @return void
  	*/
  	public function begin_execute( $action_id, $context ) {
  	if ( \defined( 'PRONAMIC_ACTION_SCHEDULER_CONTEXT' ) ) {
  	return;
  	}
  	\define( 'PRONAMIC_ACTION_SCHEDULER_CONTEXT', $context );
  	}
  	}

• https://github.com/pronamic/wp-mollie/blob/13bfb8f77bb4333c975e45093b19ffb2771d0c82/src/Client.php#L102-L147