Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: here_now #96

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix: here_now #96

merged 3 commits into from
Oct 25, 2023

Conversation

mohitpubnub
Copy link
Contributor

fix: hereNow api call without channels specified generates incorrect rest url.

Fixes issue of getting error when hereNow is called with channelGroups param only.

@mohitpubnub mohitpubnub requested a review from parfeon as a code owner October 24, 2023 13:19
@mohitpubnub mohitpubnub self-assigned this Oct 24, 2023
@mohitpubnub mohitpubnub added status: done This issue is considered resolved. priority: medium This PR should be reviewed after all high priority PRs. type: fix This PR contains fixes to existing features. labels Oct 24, 2023
Copy link
Contributor

@parfeon parfeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohitpubnub
Copy link
Contributor Author

@pubnub-release-bot release as v7.1.1

@mohitpubnub mohitpubnub merged commit 3f06c88 into master Oct 25, 2023
4 checks passed
@mohitpubnub mohitpubnub deleted the fix/listener branch October 25, 2023 08:22
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved. type: fix This PR contains fixes to existing features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants