Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create nginx config using a template, not files #4349

Open
1 task done
acozine opened this issue Oct 2, 2023 · 3 comments · May be fixed by #4654
Open
1 task done

Create nginx config using a template, not files #4349

acozine opened this issue Oct 2, 2023 · 3 comments · May be fixed by #4654
Labels
post-incident created from a post-incident meeting

Comments

@acozine
Copy link
Contributor

acozine commented Oct 2, 2023 •
edited
Loading

Right now we copy static config files from /roles/nginxplus/files/http/conf/ to the load balancers. This has some drawbacks:

  • deploying config is slow
  • when we delete a site, we have to delete the entire directory to get rid of its config file
  • separate files make it hard to see where our configuration diverges
  • small fixes like the one for [nginx] Fix nginx warnings #4090 require editing dozens of files

Replacing static files with a template should include:

  • add vars for things that do diverge, including health_check_path

We may need to retain a few static config files for a while at least; figure out how the two types of config can co-exist.
@acozine acozine added the post-incident created from a post-incident meeting label Oct 2, 2023
@acozine
Copy link
Contributor Author

acozine commented Oct 2, 2023

#4231 is a start on this work.

@carolyncole
Copy link
Member

After this work is complete “evaluate if adding a capistrano-like deployment method would make nginx+ more stable.”

@acozine
Copy link
Contributor Author

acozine commented Oct 11, 2023

Per @maxkadel the allsearch configs would be a good first test. Per @bess we will follow a phased approach, moving one or two configs to the template at a time.

@acozine acozine mentioned this issue Oct 11, 2023
Closed
@acozine acozine mentioned this issue Feb 2, 2024
Closed
@acozine acozine linked a pull request Feb 9, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
post-incident created from a post-incident meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Offer a template for nginx config files pulibrary/princeton_ansible
2 participants
@acozine @carolyncole