unwanted dependency on the File['/opt'] resource

[drdam02]

When using this module to manage Nexus repo, you create a hard dependency on the /opt folder.

Since you are using the mkdir_p function to create a recursive path to the sonatine installation, you can potentially run into troubles.

For example. We use different stages to order Puppet changes. Some of those changes are needed to install custom certificate authorities in order to be able to connect to .. Nexus.

But these certs can't be installed on the Nexus machines themselves because the actual Nexus installation is done in the main stage.

Any other change by any application in the /opt folder is dependent on the success of the Nexus module, which is not an ideal situation.

Can this be changed in the module somehow? by removing your dependency on mkdir_p ?

[TuningYourCode]

Well, we could probably change that but would most likely be a breaking change for user of this module which do not use the (new) default installation path.

As mkdir_p is no custom function from us and other modules also use it how do you handle these cases?

As we use the module default path i would merge a PR if you provide the changes as long as the module works with it's default config.

Most likely the best solution would be to introduce a new parameter like Boolean $manage_install_root and just enable the possibility to disable our mkdir_p code path which would you have to take care in your own profile code then.