Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated files need puppet "warning" in comment header #2

Open
hairmare opened this issue Jun 7, 2013 · 1 comment
Open

generated files need puppet "warning" in comment header #2

hairmare opened this issue Jun 7, 2013 · 1 comment

Comments

@hairmare
Copy link
Contributor

hairmare commented Jun 7, 2013

All generated files should contain the following comment on their first line.

# this file is managed by the syslogng puppet module

Spec MUST be implemented for all file resources in /etc/syslog-ng.

It SHOULD be implemented along the lines of

file { 'file.conf':
  contents => [
    '# this file is managed by the syslogng puppet module',
    template('file.erb'),
  ],
}

It MAY make the message configurable as a param. Doing so it MUST add spec for a default and the configured value. The param SHOULD be on the main syslogng class and only on that.

olasd added a commit to olasd/puppet-syslogng that referenced this issue Oct 21, 2013
The new "purge_conf_dir" variable lets the syslogng module enforce that all
the files in the conf_dire are managed by puppet

Closes: purplehazech#2
@hairmare
Copy link
Contributor Author

This was also intended to help admins that are new to puppet. In the light of this I'm considering to change the purging config to true as default for the 1.0.0 release. I'll have to get input on this from my syslog crack as well as sleep over this some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant