Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement(membership): update choices for membership levels #2566

Open
JacobCoffee opened this issue Sep 16, 2024 · 2 comments · May be fixed by #2689
Open

Enhancement(membership): update choices for membership levels #2566

JacobCoffee opened this issue Sep 16, 2024 · 2 comments · May be fixed by #2689
Labels
app/psf-membership Relates to the membership app backend Relates to the backend of the app

Comments

@JacobCoffee
Copy link
Member

JacobCoffee commented Sep 16, 2024 •
edited
Loading

What

pythondotorg/users/models.py

Lines 84 to 91 in fc856dd

MEMBERSHIP_CHOICES = (
(BASIC, 'Basic Member'),
(SUPPORTING, 'Supporting Member'),
(SPONSOR, 'Sponsor Member'),
(MANAGING, 'Managing Member'),
(CONTRIBUTING, 'Contributing Member'),
(FELLOW, 'Fellow'),
)
is outdated and needs to have its choices fixed following the bylaw change in psf/bylaws#4
@JacobCoffee JacobCoffee added backend Relates to the backend of the app app/psf-membership Relates to the membership app labels Sep 16, 2024
@dorian-adams
Copy link
Contributor

@JacobCoffee Just to clarify, are there users in the database with a membership type that’s planned for removal? If so, would it be helpful for me to create a function to convert those users to “basic” or some other type?

@JacobCoffee
Copy link
Member Author

There are definitely managing members that would need to be converted to contributing members per the bylaw changes.

dorian-adams added a commit to dorian-adams/pythondotorg that referenced this issue Jan 22, 2025
@dorian-adams
Update membership types: merge Managing into Contributing
f65ca85 
Update `membership_type` on `Membership` model to reflect 2024 Bylaws Change 1 (psf/bylaws#4)

- Create data migration to merge `MANAGING` (3) into `CONTRIBUTING` (4).
- Update `Membership` model, remove `MANAGING`.
- Update all references: `MANAGING` to `CONTRIBUTING`.

Left gap in `membership_type` choice values to ease data migration process.

Closes python#2566
@dorian-adams dorian-adams linked a pull request Jan 22, 2025 that will close this issue
Open
dorian-adams added a commit to dorian-adams/pythondotorg that referenced this issue Jan 22, 2025
@dorian-adams
Update membership types: merge Managing into Contributing
c809c88 
Update `membership_type` on `Membership` model to reflect 2024 Bylaws Change 1 (psf/bylaws#4)

- Create data migration to merge `MANAGING` (3) into `CONTRIBUTING` (4).
- Update `Membership` model, remove `MANAGING`.
- Update all references: `MANAGING` to `CONTRIBUTING`.

Left gap in `membership_type` choice values to ease data migration process.

Closes python#2566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app/psf-membership Relates to the membership app backend Relates to the backend of the app
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement(Membership): Update choices for membership type dorian-adams/pythondotorg
2 participants
@JacobCoffee @dorian-adams