Add initial support for blacken-region #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution! Should it dedent and reindent region before applying black to it? |
|
@proofit404 Did my best to implement dedent-/reindent-ing the region. It works pretty well with valid python blocks, however, when I run it on an invalid block, it doesn't actually abort when black fails. I tried catching the error from |
|
Tried something like (condition-case err
(blacken-buffer)
(throw 'err err))but it wouldn't cancel any of execution beneath it either way, could it be because |
|
To be honest I have no idea either. |
|
@proofit404 Ait, gonna have another go at this soon-ish |
|
see #25 for a wider discussion about this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11
Hacked together this quick implementation of blacken-region, but also my first serious attempt at elisp aside from my personal emacs configuration.
This will only work with valid top-level python blocks, as it copies the region to a new buffer, with leading whitespaces and all.
Would be nice to handle it, as mentioned here, but frankly I don't know enough about elisp to implement it myself
Feel free to suggest improvements!