Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support fused float8 gemm + bias add in torchao.float8 #1549

Open
vkuzo opened this issue Jan 11, 2025 · 0 comments
Open

support fused float8 gemm + bias add in torchao.float8 #1549

vkuzo opened this issue Jan 11, 2025 · 0 comments
Assignees
Labels

Comments

@vkuzo
Copy link
Contributor

vkuzo commented Jan 11, 2025

We've had a customer report that the bert-base-cased HuggingFace model's pooler module is especially sensitive to float8 quantization during training, and after debugging a bit evidence points to the fact that supporting fused float8 gemm + bias will help in this case.

Code pointer:

output = output + self.bias.to(output.dtype)

torch._scaled_mm supports bias, so we just need to rewire the Float8Linear code.

@vkuzo vkuzo self-assigned this Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants