Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zlib support to Decompressor #1163

Open
JohnHBrock opened this issue May 17, 2023 · 1 comment · May be fixed by #1189
Open

Add zlib support to Decompressor #1163

JohnHBrock opened this issue May 17, 2023 · 1 comment · May be fixed by #1189

Comments

@JohnHBrock
Copy link

🚀 The feature

Add support to Decompressor for file_type="zlib", and add a corresponding ZlibFileLoader.

Motivation, pitch

zlib is a very popular format, but Decompressor doesn't seem to support it (AFAICT it only supports gzip, lzma, tar, zip, and bzip2). I ran into this while working with a large dataset compressed using zlib and had to roll my own solution.

Alternatives

No response

Additional context

I'm happy to submit a PR implementing this.
@ejguan
Copy link
Contributor

ejguan commented May 17, 2023

Pls feel free to open a PR to add it.

@JohnHBrock JohnHBrock linked a pull request Jun 18, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add zlib support to Decompressor JohnHBrock/data
2 participants
@JohnHBrock @ejguan