Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First example dataset for instruct datasets has no _component #2215

Open
johnowhitaker opened this issue Dec 30, 2024 · 1 comment
Open

First example dataset for instruct datasets has no _component #2215

johnowhitaker opened this issue Dec 30, 2024 · 1 comment

Comments

@johnowhitaker
Copy link

https://pytorch.org/torchtune/stable/basics/instruct_datasets.html

I based my work (first ever torchtune attempt) on the first example on this page, and had an error until I added _component_: torchtune.datasets.instruct_dataset which is in the later examples but not the first one.

Also, as a general note, it took a surprising amount of looking starting from the "first fine-tune" tutorial (https://pytorch.org/torchtune/stable/tutorials/first_finetune_tutorial.html#) and the how-too guide (https://www.llama.com/docs/how-to-guides/fine-tuning/) to start answering the (IMO important!) question of: "How do I specify what data to train on?!?"

@RdoubleA
Copy link
Contributor

RdoubleA commented Jan 1, 2025

You are correct, the first example is missing the _component_: torchtune.datasets.instruct_dataset field. Good catch. We welcome a PR to quickly patch that, or we can flag it for now and have it patched soon.

to start answering the (IMO important!) question of: "How do I specify what data to train on?!?"

I agree this is the most important question when fine-tuning an LLM. I've been meaning to make this a bit more visible in the documentation by adding a custom data page under "Basics" or "Tutorials", this is still on our todo list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants