Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CodeQL code scanning warnings introduced by PR #6823 #6832

Open
mhucka opened this issue Dec 11, 2024 · 2 comments
Open

Fix CodeQL code scanning warnings introduced by PR #6823 #6832

mhucka opened this issue Dec 11, 2024 · 2 comments
Assignees
@mhucka
Labels
area/ci kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@mhucka
Copy link
Contributor

mhucka commented Dec 11, 2024

Description of the issue

The update of codecov/codecov-action in ci.yml from version 4 to version 5 (a result of PR #6823 ) is now leading to warnings during PR checks:

image

It's not immediately clear what is causing this, because we don't actually seem to have a CodeQL config file.
@mhucka mhucka added the kind/health For CI/testing/release process/refactoring/technical debt items label Dec 11, 2024
@NoureldinYosri NoureldinYosri added the triage/discuss Needs decision / discussion, bring these up during Cirq Cynque label Dec 11, 2024
@mhucka
Copy link
Contributor Author

mhucka commented Dec 11, 2024

Discussed during Cirq Cynq 2024-12-11: we should check previous PR checks to see if they showed up before the recent dependabot configuration change. This might still be a side-effect of the dependabot.yml configuration.

@mhucka mhucka added triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on area/ci and removed triage/discuss Needs decision / discussion, bring these up during Cirq Cynque labels Dec 11, 2024
@mhucka
Copy link
Contributor Author

mhucka commented Dec 20, 2024

The discussion at github/codeql-action#1179 may yield some clues about what's going on.

@mhucka mhucka self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhucka mhucka

Labels
area/ci kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhucka @NoureldinYosri