Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move apt-system-requirements.txt into apt-list-dev-tools.txt #6934

Open
mhucka opened this issue Jan 9, 2025 · 0 comments
Open

Move apt-system-requirements.txt into apt-list-dev-tools.txt #6934

mhucka opened this issue Jan 9, 2025 · 0 comments
Labels
kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@mhucka
Copy link
Contributor

mhucka commented Jan 9, 2025

Description of the issue

There is a file apt-system-requirements.txt at the top level of the Cirq repo. As far as I can find, the only place this file is referenced is in docs/dev/development.md, where the instructions say to do this:

cat apt-system-requirements.txt dev_tools/conf/apt-list-dev-tools.txt | xargs sudo apt-get install --yes

The file systems to have been introduced back in 2018. It looks like things may have been refactored and moved around since then. It's not obvious why there's a split between the two files (apt-system-requirements.txt and apt-list-dev-tools.txt), and so, I'd like to propose that we merge the content of apt-system-requirements.txt into apt-list-dev-tools.txt and get rid of the former file. The rationale is to simplify things a little bit and slightly reduce confusion.

Cirq version

1.5.0.dev

@mhucka mhucka added the kind/health For CI/testing/release process/refactoring/technical debt items label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
Development

No branches or pull requests

1 participant