You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems like the pr_monitor bot for Cirq is not currently running. Issue #6024 suggests there was a problem last year, but it's clear if the problem was ever resolved (though the issue is still open). The files in dev_tools/pr_monitor/ and dev_tools/cirq-infra/ indicate that the bot is supposed to be running in a GCP project.
Relatedly, issue #4310 from 2021 talk about dev_tools/auto_merge.py, but that file doesn't exist anymore. It seems like its purpose is to auto-merge PRs if certain conditions are met. In issue #4852, @Strilanc suggested replacing Cirq's automerge bot with GitHub's native PR automerge feature. The reason it was not done at the time seems to be that GitHub's facility does not auto-update the branch (and it still doesn't, even today).
When added, this action will run the following tasks on pull requests with the automerge label:
Changes from the base branch will automatically be merged into the pull request (only when "Require branches to be up to date before merging" is enabled in the branch protection rules)
When the pull request is ready, it will automatically be merged. The action will only wait for status checks that are marked as required in the branch protection rules
Pull requests without any configured labels will be ignored
This appears to be basically what pr_monitor is supposed to do. If that interpretation is correct, and people agree, I'll open a PR to:
add that action & configure it
remove dev_tools/pr_monitor/
remove dev_tools/cirq-infra/
and also, if there is indeed a GCP setup somewhere for pr_monitor, we can remove that.
Cirq version
1.5.0.dev
The text was updated successfully, but these errors were encountered:
Description of the issue
It seems like the pr_monitor bot for Cirq is not currently running. Issue #6024 suggests there was a problem last year, but it's clear if the problem was ever resolved (though the issue is still open). The files in
dev_tools/pr_monitor/
anddev_tools/cirq-infra/
indicate that the bot is supposed to be running in a GCP project.Relatedly, issue #4310 from 2021 talk about
dev_tools/auto_merge.py
, but that file doesn't exist anymore. It seems like its purpose is to auto-merge PRs if certain conditions are met. In issue #4852, @Strilanc suggested replacing Cirq's automerge bot with GitHub's native PR automerge feature. The reason it was not done at the time seems to be that GitHub's facility does not auto-update the branch (and it still doesn't, even today).I looked for a GitHub setting that would make it do that, and didn't find any; however, this led to the discovery of the following GitHub Actions in the marketplace: https://github.com/marketplace/actions/merge-pull-requests-automerge-action:
This appears to be basically what pr_monitor is supposed to do. If that interpretation is correct, and people agree, I'll open a PR to:
dev_tools/pr_monitor/
dev_tools/cirq-infra/
and also, if there is indeed a GCP setup somewhere for pr_monitor, we can remove that.
Cirq version
1.5.0.dev
The text was updated successfully, but these errors were encountered: