PWA build with InjectManifest is broken

[bergmorten]

What happened?

I use @quasar/app-webpack with a vanila quasar project. Initialized with quasar cli and selected webpack. Then I added PWA mode and changed quasar.conf.ts to have workboxMode: 'InjectManifest'.

When building for PWA the sw.js files has require statements which is not supported and points to files that does not exits. It seems that the Esbuild setup does not have bundle mode enabled?

I also tried to set bundle mode true in extendPWACustomSWConf, but this did not have any effect?

    pwa: {
      workboxMode: 'InjectManifest', // 'GenerateSW' or 'InjectManifest'
      // swFilename: 'sw.js',
      // manifestFilename: 'manifest.json',
      // extendManifestJson (json) {},
      // useCredentialsForManifestTag: true,
      // injectPwaMetaTags: false,
      extendPWACustomSWConf(esbuildConf) {
        esbuildConf.bundle = true
      },
      // extendGenerateSWOptions (cfg) {},
      // extendInjectManifestOptions (cfg) {}
    },

What did you expect to happen?

The sw.js file genrated should be bundled with all imports and should not use require statements.

Reproduction URL

https://codepen.io/rstoenescu/pen/xxEvBLR

How to reproduce?

1. Init a new quasar project , when asked select webpack mode v4
2. Add mode pwa
3. Change workboxMode to 'InjectManifest' in quasar.conf.ts
4. quasar build -m pwa
5. View generated sw.js file or test quasar serve in dist/pwa and open http://localhost:4000 (console error should state that require is not supported).

Flavour

Quasar CLI with Webpack (@quasar/cli | @quasar/app-webpack)

Areas

PWA Mode

Platforms/Browsers

No response

Quasar info output

No response

Relevant log output

No response

Additional context

No response

[rstoenescu]

Fix will be available in q/app-webpack v4.0.6.
Until the release, edit quasar.config file:

pwa: {
  extendInjectManifestOptions (cfg) {
    cfg.compileSrc = false
  }
}

[rstoenescu]

Released it. Please remember to remove any of your previous quasar.config settings that you tried when reporting this bug.

[bergmorten]

Thanks, I can confirm that the PWA build does work