Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robust handling of nil default? #4

Open
paulcc opened this issue Aug 17, 2010 · 0 comments
Open

robust handling of nil default? #4

paulcc opened this issue Aug 17, 2010 · 0 comments

Comments

@paulcc
Copy link

paulcc commented Aug 17, 2010

The code doesn't handle a nil value for @current_store, eg when there's no default store

What do you think to adding relevant protection?

[Rationale: I've got a site where there's going to be a high number of stores (hundreds, perhaps!), with the ability to disable some of these, plus we want a central 'admin' site. I've set the latter up as what takes over when @current_store is nil (ie vanilla spree, really) because I wasn't keen on having this as a store. Would you have done this as a store? or do you think it's valid to side-step the mechanisms?]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant