-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
control/log connections don't show history #19
Comments
I like the idea - that was one of the things missing when moving from the former Do you want me to push to your PR? (It's your |
You're welcome to push to the PR. My fork only exists for this PR. I may also be adding a couple of minor changes later today, such as: Add a command line option to set the size of the log buffer, obey the stamplog setting for buffered log messages. |
Cool. The first of your items was also on my list... What about using -H/--history=<n> ? |
-H already appears to be used for holdoff: |
Hm. Well... -H was actually never documented and never intended to be used. (There are more of those cases: the long_options structure needs something as a short option.) |
Got it. I'll repurpose -H for history, and change the short option for --holdoff to -O. |
Perfect. |
When opening up a telnet connection to the log/control ports, it would be very useful if the last n lines of output were echoed to the terminal. This is especially useful for softIOCs that present a menu to the user.
I have a patch that adds rudimentary support for this feature. I'll create a pull request as soon as I figure out how.
The text was updated successfully, but these errors were encountered: