Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1beta2] RKE2ControlPlane - improve utilization of machineTemplate #554

Open
4 tasks
Danil-Grigorev opened this issue Jan 10, 2025 · 0 comments
Open
4 tasks

[v1beta2] RKE2ControlPlane - improve utilization of machineTemplate #554

Danil-Grigorev opened this issue Jan 10, 2025 · 0 comments
Labels
area/api Indicates an issue or PR relates to the APIs v1beta2

Comments

@Danil-Grigorev
Copy link
Contributor

Danil-Grigorev commented Jan 10, 2025 •
edited
Loading

In the new API version we should make changes to the usage of the machineTemplate to improve the UX of the API and usability with ClusterClasses (ref: issue)

  • Remove .spec.infrastructureRef in favor of .spec.machineTemplate.infrastructureRef
  • Remove .spec.nodeDrainTimeout and use .spec.machineTemplate.nodeDrainTimeout
  • Mark .spec.machineTemplate as required
  • Implement necessary conversion webhook changes to leverage field transitions.
@Danil-Grigorev Danil-Grigorev mentioned this issue Jan 10, 2025
Merged
4 tasks
@alexander-demicev alexander-demicev added area/api Indicates an issue or PR relates to the APIs v1beta2 labels Jan 10, 2025
@Danil-Grigorev Danil-Grigorev changed the title [v1beta2] RKE2ControlPlane - remove deprecated .spec.infrastructureRef in favor of .spec.machineTemplate.infrastructureRef [v1beta2] RKE2ControlPlane - improve utilization of machineTemplate Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api Indicates an issue or PR relates to the APIs v1beta2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexander-demicev @Danil-Grigorev