-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Angular 5 #85
Comments
Hey, TypeError: core_1.OpaqueToken is not a constructor After some reading, I think this is due to deprecation of OpaqueToken in Angular5 |
I've the same problem, is there any solution of this issue? |
@anvial If your app really depends on this SSR package I'd consider staying on ng4. However, if you can use dynamic prerendering in node you should definitely check out angular/universal package |
I've finally gave up this package in favor of angular/universal, the result is great. I think they solved a lot of problems with angular 5 and universal. For example they add a server side DOM with Domino, which is quite useful, also transfer state between servers and browsers... But it took me 2 days to do it, I had to solve a lots of stuff to make it work properly. |
@DenisLaboureyras Great. You have any write-up about your steps? |
@seanmavley Are You looking for static or dynamic prerendering? |
@seanmavley I don't have write-up on the subject but I will give you some advices :) First, the best starter I found is this one: Then the first big issue I encountered is that I couldn't make my app work with a full build done with webpack. The reason is that you need the factories to launch the server and as far as I know you can't produce them with webpack. So I had to configure a part of the build with angular-cli :/ I had to restructure my code a little, with a "core" module with main features of the app, and 1 browser and 1 server module for specific stuffs. The starter mentioned above has a great structure. I manage after that to build my code, but ran into different issues. First I had a very specific problem with an infinite loop because in the server render the app was not stabilizing (because of setTimeout in my code...) And finally the magic works :) After that, I've begun to add server state transfer, preboot, shared cache, ... Hope it helps. |
There, in plain Russian, it's written: "The official example on the english language: https://github.com/angular/universal-starter" Who does not know Russian, welcome: https://github.com/angular/universal-starter |
Hello,
Thanks for your awesome plugin, I've used it for 3 months now and it works like a charm.
I've tried today to upgrade my app to Angular 5, I managed to do it on my client config, but the server build is throwing me a lot of errors (see below).
Am I doing something wrong or do you plan on upgrading your module to Angular 5 ?
Kind regards,
Denis
ERROR in ./node_modules/angular-ssr/build/application/compiler/ngc/create.js
Module not found: Error: Can't resolve '@angular/compiler-cli/src/path_mapped_compiler_host' in '/home/data/app/node_modules/angular-ssr/build/application/compiler/ngc'
@ ./node_modules/angular-ssr/build/application/compiler/ngc/create.js 4:34-96
@ ./node_modules/angular-ssr/build/application/compiler/ngc/compiler.js
@ ./node_modules/angular-ssr/build/application/compiler/factory.js
@ ./node_modules/angular-ssr/build/application/compiler/index.js
@ ./node_modules/angular-ssr/build/application/index.js
@ ./node_modules/angular-ssr/build/index.js
@ ./src/angular/main.server.ts
@ ./src/angular/main.server-ssr.ts
ERROR in ./node_modules/angular-ssr/node_modules/@angular/cli/models/webpack-configs/production.js
Module not found: Error: Can't resolve '@angular/service-worker/build/webpack' in '/home/data/app/node_modules/angular-ssr/node_modules/@angular/cli/models/webpack-configs'
@ ./node_modules/angular-ssr/node_modules/@angular/cli/models/webpack-configs/production.js 74:43-91
@ ./node_modules/angular-ssr/node_modules/@angular/cli/models/webpack-configs/index.js
@ ./node_modules/angular-ssr/node_modules/@angular/cli/models/webpack-config.js
@ ./node_modules/angular-ssr/build/application/compiler/webpack/config/cli.js
@ ./node_modules/angular-ssr/build/application/compiler/webpack/config/index.js
@ ./node_modules/angular-ssr/build/application/compiler/factory.js
@ ./node_modules/angular-ssr/build/application/compiler/index.js
@ ./node_modules/angular-ssr/build/application/index.js
@ ./node_modules/angular-ssr/build/index.js
@ ./src/angular/main.server.ts
@ ./src/angular/main.server-ssr.ts
ERROR in [at-loader] ./node_modules/angular-ssr/build/application/compiler/ngc/resource-resolver.d.ts:1:10
TS2305: Module '"/home/data/app/node_modules/@angular/compiler-cli/index"' has no exported member 'ModuleResolutionHostAdapter'.
ERROR in [at-loader] ./node_modules/angular-ssr/build/platform/document/tokens.d.ts:1:10
TS2305: Module '"/home/data/app/node_modules/@angular/core/core"' has no exported member 'OpaqueToken'.
ERROR in [at-loader] ./node_modules/angular-ssr/build/platform/module/tokens.d.ts:1:10
TS2305: Module '"/home/data/app/node_modules/@angular/core/core"' has no exported member 'OpaqueToken'.
ERROR in [at-loader] ./node_modules/angular-ssr/build/platform/platform.d.ts:2:22
TS2420: Class 'ServerPlatform' incorrectly implements interface 'PlatformRef'.
Property '_injector' is missing in type 'ServerPlatform'.
The text was updated successfully, but these errors were encountered: