Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality Check on calc.c #164

Open
Pvanduyse opened this issue Dec 2, 2015 · 9 comments
Open

Quality Check on calc.c #164

Pvanduyse opened this issue Dec 2, 2015 · 9 comments

Comments

@Pvanduyse
Copy link
Collaborator

No description provided.

@Pvanduyse Pvanduyse added this to the List data type milestone Dec 2, 2015
@Pvanduyse Pvanduyse self-assigned this Dec 2, 2015
@Pvanduyse Pvanduyse changed the title Quality Check on calc.c Quality Check on calc.c Dec 2, 2015
@Pvanduyse Pvanduyse removed their assignment Dec 2, 2015
@Pvanduyse
Copy link
Collaborator Author

making it big, since calc.c is currently very sloppy and has a lot of bugs.

@Pvanduyse
Copy link
Collaborator Author

@plankp can you change the calc.c function so that the args is now an list with the arguments as strings? calc.c would need to concat all of the strings then dissect it.

@plankp
Copy link
Collaborator

plankp commented Dec 3, 2015

?

@Pvanduyse
Copy link
Collaborator Author

The new kernelFunction.c will now be passing a list for the args, instead of a string, with spaces dividing the different args. Since some people might use spaces in the equation, it would be good to concat all of the args together, and then dissect that for the calc. Please start working on a version of calc.c that will take a list as input. (The list will have been shrunk previously)

@plankp
Copy link
Collaborator

plankp commented Dec 3, 2015

A list of args? so for example a input like calc -r 10 - 2 will become ["calc", "-r", "10", "-", "2"]?

@Pvanduyse
Copy link
Collaborator Author

actually, i can remove the "calc" argument first, but yea, that's the idea.

@plankp
Copy link
Collaborator

plankp commented Dec 3, 2015

Does it pass arguments like that yet?

@Pvanduyse
Copy link
Collaborator Author

once i integrate the updated kernelFunctions.c. Right now it still gives me errors, and i can't finish the integration till tonight.

@plankp
Copy link
Collaborator

plankp commented Dec 3, 2015

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants