Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audiobooks stop playing after a couple of minutes #176

Closed
codegrizzl opened this issue Dec 6, 2024 · 14 comments
Closed

audiobooks stop playing after a couple of minutes #176

codegrizzl opened this issue Dec 6, 2024 · 14 comments

Comments

@codegrizzl
Copy link

Since a couple of days ago, audiobooks stop playing after a couple of minutes. It does not matter if they are downloaded or streamed. The stop seams kind of consistent, I have not timed it for now. As it stands I can currently not listen to an audiobook.

Format of my audiobooks is m4b.

This error does not happen with podcasts. But they are stored in mp3, if the error is connected to the file format.

I am currently at the newest version 2.5.1

Does someone have the same issue?

@rasmuslos
Copy link
Owner

I think this is caused by checkPlayerTimeout because it assumes that some variable is nil when it isn’t.

@rasmuslos
Copy link
Owner

Possibly related to #178

@codegrizzl
Copy link
Author

codegrizzl commented Dec 9, 2024 via email

@rasmuslos
Copy link
Owner

What version of iOS are you using?

@codegrizzl
Copy link
Author

codegrizzl commented Dec 9, 2024 via email

@rasmuslos
Copy link
Owner

I have an idea for debugging this, but we should make sure that the app doesn't crash first. Does the playback just stop (the app stays open) or does it crash?

@codegrizzl
Copy link
Author

codegrizzl commented Dec 10, 2024 via email

@rasmuslos
Copy link
Owner

I think this is caused by ProgressEntity's being modified on background threads, most likely when the device is busy with doing other things. I am currently reworking the logic, but it takes time...

@zagahr
Copy link

zagahr commented Dec 17, 2024

I have the same issue — the app crashes after a few minutes, regardless of whether it is open or running in the background.

@rasmuslos
Copy link
Owner

Check with 2.5.2 once it is released

@rasmuslos
Copy link
Owner

#189

@fmartingr
Copy link

I know this is closed in favor of #189, but just giving more information about this specific issue that I'm also experiencing: in my case this seems to only happen in background, after a few minutes (unsure if it's fixed or not, sorry), but so far if I have the application open it does not crash.

@rasmuslos
Copy link
Owner

This stuff is really annoying to debug, because of that reason, but I still think I this is caused by a concurrency issue. If you leave the app in the foreground swift schedules most of the work on the main thread, but if you put it in the background some things (like updating a progress entity) may happen on some background thread.

@fmartingr
Copy link

This stuff is really annoying to debug, because of that reason, but I still think I this is caused by a concurrency issue. If you leave the app in the foreground swift schedules most of the work on the main thread, but if you put it in the background some things (like updating a progress entity) may happen on some background thread.

If I can help in any way, let me know. I use ShelfPlayer almost on a daily basis. Maybe running a TestFlight build with more debugging information or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants