-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] add a doc for sharing a Grafana instance across multiple KubeRay custom resources #49742
Merged
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
win5923
requested review from
maxpumperla,
pcmoritz,
kevin85421 and
a team
as code owners
January 9, 2025 16:03
win5923
force-pushed
the
grafana/filterRayClusters
branch
3 times, most recently
from
January 9, 2025 16:09
556731e
to
57e74f6
Compare
win5923
force-pushed
the
grafana/filterRayClusters
branch
from
January 11, 2025 02:34
57e74f6
to
0769db1
Compare
kevin85421
reviewed
Jan 13, 2025
doc/source/cluster/kubernetes/k8s-ecosystem/prometheus-grafana.md
Outdated
Show resolved
Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/prometheus-grafana.md
Outdated
Show resolved
Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/prometheus-grafana.md
Outdated
Show resolved
Hide resolved
…y custom resources Signed-off-by: win5923 <[email protected]>
win5923
force-pushed
the
grafana/filterRayClusters
branch
from
January 14, 2025 01:17
0769db1
to
5e7d36e
Compare
kevin85421
approved these changes
Jan 14, 2025
angelinalg
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some style nits for passive voice.
doc/source/cluster/kubernetes/k8s-ecosystem/prometheus-grafana.md
Outdated
Show resolved
Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/prometheus-grafana.md
Outdated
Show resolved
Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/prometheus-grafana.md
Outdated
Show resolved
Hide resolved
doc/source/cluster/kubernetes/k8s-ecosystem/prometheus-grafana.md
Outdated
Show resolved
Hide resolved
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Blocka <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Blocka <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Blocka <[email protected]>
Co-authored-by: angelinalg <[email protected]> Signed-off-by: Blocka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Update the Ray doc to see the metrics for a single RayCluster CR in a shared Grafana instance, also fixed some incorrect URL.
The Case1 import method needs to wait until ray-project/kuberay#2685 is merged.
Related issue number
Closes ray-project/kuberay#2668
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.