Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Move validateRay[Cluster|Job|Service][Spec|Status] to a new file validation.go #2740

Open
1 of 2 tasks
kevin85421 opened this issue Jan 13, 2025 · 3 comments
Open
1 of 2 tasks

[Refactor] Move validateRay[Cluster|Job|Service][Spec|Status] to a new file validation.go #2740

kevin85421 opened this issue Jan 13, 2025 · 3 comments
Assignees
@CheyuWu
Labels
enhancement New feature or request refactor

Comments

@kevin85421
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Currently, validateRay[Cluster|Job|Service][Spec|Status] functions are in the separate controller.go. Move it to ray/utils/validation.go so that other projects can also rely on the functions to validate CRs.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added enhancement New feature or request triage refactor and removed triage labels Jan 13, 2025
@kevin85421
Copy link
Member Author

/assign @CheyuWu

@kevin85421
Copy link
Member Author

This is a follow up of #2738

@CheyuWu
Copy link
Contributor

CheyuWu commented Jan 14, 2025

I would like to help with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CheyuWu CheyuWu

Labels
enhancement New feature or request refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevin85421 @CheyuWu