Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Move functions that don’t rely on the controller to non-controller member functions #2741

Open
1 of 2 tasks
kevin85421 opened this issue Jan 13, 2025 · 4 comments · May be fixed by #2747
Open
1 of 2 tasks

[Refactor] Move functions that don’t rely on the controller to non-controller member functions #2741

kevin85421 opened this issue Jan 13, 2025 · 4 comments · May be fixed by #2747
Assignees
@win5923
Labels
enhancement New feature or request refactor

Comments

@kevin85421
Copy link
Member

kevin85421 commented Jan 13, 2025 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Example: #2738

If the function requires rewriting tests or adding new unit tests, it’s better to separate them into different PRs. Don’t include everything in a single PR to make it easier to review.

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added enhancement New feature or request triage refactor and removed triage labels Jan 13, 2025
@kevin85421
Copy link
Member Author

/assign @owenowenisme

@owenowenisme
Copy link
Contributor

take

@kevin85421
Copy link
Member Author

I chatted with @owenowenisme offline. He has some travel plans recently, so I will find someone else to take on the issue.

@win5923
Copy link
Contributor

win5923 commented Jan 14, 2025

Hi @kevin85421, Can i take this?

@win5923 win5923 linked a pull request Jan 14, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@win5923 win5923

Labels
enhancement New feature or request refactor
Projects
None yet
Milestone
No milestone
3 participants
@kevin85421 @win5923 @owenowenisme