Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Approver still see appeal after they got removed from the approver list #276

Open
rahmatrhd opened this issue Sep 2, 2022 · 0 comments
Open

Approver still see appeal after they got removed from the approver list #276

rahmatrhd opened this issue Sep 2, 2022 · 0 comments
Labels
appeal bug Something isn't working

Comments

@rahmatrhd
Copy link
Member

Description
After removing an approver from an appeal, they still see that appeal in their approvals list (GetUserApprovals)

To Reproduce

  1. Remove an approver from an appeal
  2. Ask the removed approver to access GetUserApprovals or GET /me/approvals
  3. They will still see the same appeal listed in the response

Proposed Solution
This happens because of soft deletion. Need to update the query to add condition: WHERE deleted_at IS NULL in list approvals API
@rahmatrhd rahmatrhd added bug Something isn't working appeal labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
appeal bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rahmatrhd