-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guess_dates should accept vector of column names in clean_dates #76
Comments
guess_dates() explicitly works on vectors. Would this not be taken care of by the |
Sorry, I meant the |
Not entirely sure how straightforward the added feature would be. @zkamvar do you think this belong to the prep of release 0.1.0 or shall we put a pin in it for later releases? For what it's worth, an easy workaround would be, e.g. with dates columns containing the x %>%
clean_data() %>%
mutate_at(vars(contains("date")), guess_dates, error_tolerance = 1) Assuming a default |
Because there is a workaround, I would be much happier to put this on the backburner. |
Perf, untagging this from the project for the first release, and we can always get to this later. @scottyaz most welcome to PR this if you feel like it ;) |
It would be helpful to also allow for character vector specifying column names (or even in tidy notation
col_a:col_m
. Note this is not a bug.The text was updated successfully, but these errors were encountered: