From 5be6f2670971f545e02ecf39e772283dd4bf6629 Mon Sep 17 00:00:00 2001
From: Rafid Aslam <rafidteam@gmail.com>
Date: Sun, 24 Mar 2019 19:39:43 +0700
Subject: [PATCH] Add flake8 check to Travis-CI matrix

Closes https://github.com/kiwix/kiwix-build/issues/263
---
 .travis.yml             | 25 +++++--------------------
 setup.cfg               | 40 ++++++++++++++++++++++++++++++++++++++++
 travis/travis_script.sh | 23 +++++++++++++++++++++++
 3 files changed, 68 insertions(+), 20 deletions(-)
 create mode 100644 setup.cfg
 create mode 100644 travis/travis_script.sh

diff --git a/.travis.yml b/.travis.yml
index c72a6439..3dc77d43 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -27,26 +27,10 @@ cache:
     - $HOME/.gradle/caches/
     - $HOME/.gradle/wrapper/
     - $HOME/.android/build-cache
-install: if [[ $TRAVIS_OS_NAME != "linux" || $DESKTOP_ONLY != 1 ]]; then travis/install_extra_deps.sh; fi
-script:
-- |
-  if [[ $TRAVIS_OS_NAME = "linux" && $DESKTOP_ONLY == 1 ]]
-  then
-    if [[ $PLATFORM = "flatpak" ]]
-    then
-      docker build -t kiwix/build -f travis/Dockerfile_flatpak .
-    else
-      docker build -t kiwix/build -f travis/Dockerfile .
-    fi
-    docker run -e PLATFORM -e NIGHTLY_DATE -e TRAVIS_EVENT_TYPE -e DESKTOP_ONLY -e TRAVIS_TAG --device /dev/fuse --cap-add ALL --privileged kiwix/build
-  else
-    if [[ $TRAVIS_OS_NAME = "linux" ]]
-    then
-      python3.5 travis/compile_all.py
-    else
-      python3 travis/compile_all.py
-    fi
-  fi
+install:
+  - if [[ $TRAVIS_OS_NAME != "linux" || $DESKTOP_ONLY != 1 ]]; then travis/install_extra_deps.sh; fi
+  - if [[ $TEST_SUITE == "flake8_check"]]; then python3 pip install flake8; fi
+script: travis/travis_script.sh
 after_failure: travis/upload_all_log.sh
 deploy:
   - provider: script
@@ -145,6 +129,7 @@ matrix:
       os: osx
     - env: PLATFORM="iOS_i386"
       os: osx
+    - env: TEST_SUITE="flake8_check"
 
 notifications:
   irc:
diff --git a/setup.cfg b/setup.cfg
new file mode 100644
index 00000000..57afeffc
--- /dev/null
+++ b/setup.cfg
@@ -0,0 +1,40 @@
+[flake8]
+ignore =
+    E201, # whitespace after '{'
+    E202, # whitespace before '}'
+    E501, # line too long
+    E128, # continuation line under-indented for visual indent
+    E226, # missing whitespace around arithmetic operator
+    E126, # continuation line over-indented for hanging indent
+    E203, # whitespace before ':'
+    E111, # indentation is not a multiple of four
+    E261, # at least two spaces before inline comment
+    E124, # closing bracket does not match visual indentation
+    E731, # do not assign a lambda expression, use a def
+    E401, # multiple imports on one line
+    E302, # expected 2 blank lines, found 1
+    W503, # line break before binary operator
+    E231, # missing whitespace after ':'
+    E303, # too many blank lines (2)
+    E302, # expected 2 blank lines, found 1
+    E305, # expected 2 blank lines after class or function definition, found 1
+    F401, # 'X' imported but unused
+    F821, # undefined name 'X'
+    E228, # missing whitespace around modulo operator
+    E999, # SyntaxError: invalid syntax
+    E225, # missing whitespace around operator
+    F403, # 'from .base import *' used; unable to detect undefined names
+    W391, # blank line at end of file
+    E122, # continuation line missing indentation or outdented
+    E251, # unexpected spaces around keyword / parameter equals
+    E713, # test for membership should be 'not in'
+    E722, # do not use bare except'
+    E129, # visually indented line with same indent as next logical line
+    E301, # expected 1 blank line, found 0
+    E121, # continuation line under-indented for hanging indent
+    E123, # closing bracket does not match indentation of opening bracket's line
+    E127, # continuation line over-indented for visual indent
+    E222, # multiple spaces after operator
+    E265, # block comment should start with '# '
+    F811, # redefinition of unused X
+    E222, # multiple spaces after operator
diff --git a/travis/travis_script.sh b/travis/travis_script.sh
new file mode 100644
index 00000000..c961bfdb
--- /dev/null
+++ b/travis/travis_script.sh
@@ -0,0 +1,23 @@
+#!/usr/bin/env bash
+if [[ $TEST_SUITE = "flake8_check" ]]
+then
+  flake8 .
+else
+  if [[ $TRAVIS_OS_NAME = "linux" && $DESKTOP_ONLY == 1 ]]
+  then
+    if [[ $PLATFORM = "flatpak" ]]
+    then
+      docker build -t kiwix/build -f travis/Dockerfile_flatpak .
+    else
+      docker build -t kiwix/build -f travis/Dockerfile .
+    fi
+    docker run -e PLATFORM -e NIGHTLY_DATE -e TRAVIS_EVENT_TYPE -e DESKTOP_ONLY -e TRAVIS_TAG --device /dev/fuse --cap-add ALL --privileged kiwix/build
+  else
+    if [[ $TRAVIS_OS_NAME = "linux" ]]
+    then
+      python3.5 travis/compile_all.py
+    else
+      python3 travis/compile_all.py
+    fi
+  fi
+fi