Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to send keep-alives on idle connections #86

Open
rajesh-blueshift opened this issue May 20, 2024 · 3 comments · May be fixed by #87
Open

Request to send keep-alives on idle connections #86

rajesh-blueshift opened this issue May 20, 2024 · 3 comments · May be fixed by #87

Comments

@rajesh-blueshift
Copy link

rajesh-blueshift commented May 20, 2024

Dear team,

We have deployed our push service using a2 into production, but we are frequently observing ConnectionReset errors on http2 connections.
image

Our service is multi-tenant and the traffic is a steady stream of messages with idle periods and bursts in between.
Although we are working around these connection resets by retrying it. I was thinking if we could do something like sending periodic keep-alive messages over the open connection.

The pushy library already does something like this: jchambers/pushy#266

I read through the hyper documentation, and the default is to not send any keep-alives

@chris13524 chris13524 linked a pull request May 20, 2024 that will close this issue
3 tasks
@chris13524
Copy link
Member

chris13524 commented May 20, 2024

I opened a PR to send the PING every 1 hour as per the recommendation by the APNs docs. Nothing though that there may be other factors causing connection resets (e.g. APNs closing the connection or network problems) so you should still use retries.

#87

@rajesh-blueshift
Copy link
Author

Makes sense. Thanks for helping on this one. I appreciate it

@rajesh-blueshift
Copy link
Author

Connection resets have stopped now. Thanks for a quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants