New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`diffoci rm` does not collect garbage blobs when running with `local` backend #3

Open

AkihiroSuda opened this issue Aug 23, 2023 · 0 comments

Labels

bug

Member

AkihiroSuda commented Aug 23, 2023

diffoci/cmd/diffoci/commands/remove/remove.go

Lines 21 to 23 in 63094dc

    
           BUG: when using the "local" backend, the remove command 
        
           does not remove blobs associated with the image. 
        
           (Workaround: remove the cache directory periodically by yourself.)

GC here does not seem working as expected

diffoci/cmd/diffoci/commands/remove/remove.go

Lines 55 to 57 in 63094dc

    
           if gcErr := backend.MaybeGC(ctx); gcErr != nil { 
        
           	log.G(ctx).WithError(gcErr).Warn("Failed to do GC") 
        
           }

AkihiroSuda added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment