Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omni completion doesn't work: complete/completion mismatch #56

Open
rnmmnen opened this issue Feb 8, 2022 · 1 comment
Open

Omni completion doesn't work: complete/completion mismatch #56

rnmmnen opened this issue Feb 8, 2022 · 1 comment

Comments

@rnmmnen
Copy link

rnmmnen commented Feb 8, 2022

vim-rescript tries to use complete:

let l:command = g:rescript_analysis_exe . " complete " . @% . " " . ( c_line - 1) . " " . (c_col - 1) . " " . l:tmpname

The underlying rescript-editor-analysis.exe expects completion:

https://github.com/rescript-lang/rescript-vscode/blob/master/analysis/src/Cli.ml#L66

@rnmmnen rnmmnen changed the title Omnicomplete doesn't work: complete/completion mismatch Omni completion doesn't work: complete/completion mismatch Feb 9, 2022
@ryyppy
Copy link
Member

ryyppy commented Dec 15, 2022

Yeah that was a legit change from this commit which I didn't notice until now:
rescript-lang/rescript-vscode@d818310

Since we are vendoring the language server right now, we may even change this right after updating to the latest LSP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants