Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Img styles are not properly included making profile image embeds display incorrectly #7

Open
Stvad opened this issue Jan 1, 2025 · 2 comments

Comments

@Stvad
Copy link

Stvad commented Jan 1, 2025

image

If I add the CSS file provided by the package - it seems like the styles for img are missing/misconfigured resulting in profile image not displaying correctly

The profile image display starts working correctly if I copy the following style from the docs page:

img, video {
    max-width: 100%;
    height: auto;
}
@LuckySharma014
Copy link
Member

We implemented it this way to provide flexibility, allowing you to use your own global CSS for the <img> and <video> tags if needed. Alternatively, if you prefer to use our styles, you can simply apply the CSS you have already copied.

@Stvad
Copy link
Author

Stvad commented Jan 23, 2025

Hmm, this doesn't make sense to me? These don't need to be global img/video styles - they just need to apply within the component, otherwise the image/video display within the component is broken with the CSS you provide.

Also when I say I copied it from the docs page is not that it's documented as an option, it's me investigating - why is image display broken for me when I use the CSS shipped with the package, and discovering you applying those global styles in your example to make it work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants