Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Missing tests for word-diff feature #72

Open
MisanthropicBit opened this issue Feb 18, 2021 · 3 comments
Open

[Question] Missing tests for word-diff feature #72

MisanthropicBit opened this issue Feb 18, 2021 · 3 comments

Comments

@MisanthropicBit
Copy link
Contributor

As mentioned here, I was still in the process of making tests for the word-diff feature #69.

I can still create them but I didn't get that far if you want to create them yourself :)

@rhysd
Copy link
Owner

rhysd commented Feb 20, 2021

Yes, adding unit tests is welcome. I think test cases for d -> d and d -> D are helpful for understanding how to test them.

I also thought adding the tests. So it's ok to add them by me if you're busy.

@MisanthropicBit
Copy link
Contributor Author

I think test cases for d -> d and d -> D are helpful for understanding how to test them.

Thanks, I based my tests on those.

I can certainly work on the tests although I don't know when they'll be ready so if you prefer to make them yourself then by all means do. If not, I'll get started when I have time :)

@rhysd
Copy link
Owner

rhysd commented Mar 1, 2021

OK, I'll leave comment here when I start the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants