Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reports endpoint giving wrong results #206

Open
saurabhdaga-merkle opened this issue Sep 6, 2020 · 4 comments
Open

reports endpoint giving wrong results #206

saurabhdaga-merkle opened this issue Sep 6, 2020 · 4 comments

Comments

@saurabhdaga-merkle
Copy link

saurabhdaga-merkle commented Sep 6, 2020

https://xrpl.org/data-api-v2-tool.html#get-daily-reports

2013-01-25T00:00:00Z
?
accounts=true&payments=true

The results for address:

 {
      "account": "rp1Ve83fKy5XbNMkaNmkEbgRp4HJhuKoX3",
      "date": "2013-01-25T00:00:00Z",
      "high_value_received": "1000",
      "high_value_sent": "0",
      "payments": [
        {
          "tx_hash": "B18BA111B438EA9AAEE416C430C5141E93B0B43725AEB4F278996520B61953A1",
          "amount": "2",
          "issuer": "rp1Ve83fKy5XbNMkaNmkEbgRp4HJhuKoX3",
          "type": "received"
        },
        {
          "tx_hash": "049DC2035178864E6D3360A53D2CC8A4B5E17711BD729CE964D63587DDF8AEF4",
          "amount": "2",
          "issuer": "rp1Ve83fKy5XbNMkaNmkEbgRp4HJhuKoX3",
          "type": "sent"
        },
        {
          "tx_hash": "25B02E0BA85D471BE3E1576BAD01FD3EBB51482EDCC4319688E99A77067AA458",
          "amount": "1",
          "issuer": "rp1Ve83fKy5XbNMkaNmkEbgRp4HJhuKoX3",
          "type": "sent"
        },
        {
          "tx_hash": "2DF1C6299709D5BB13FF3C298E89FE61A09D3A4B692F93002E36CC26BFF8860B",
          "amount": "1000",
          "type": "sent"
        }
      ],
      "payments_received": 4,
      "payments_sent": 0,
      "receiving_counterparties": [
        "rGJ3MKc1mdQFt1RU8g7FzbajaXpbmjVYJ"
      ],
      "sending_counterparties": [
        "rGJ3MKc1mdQFt1RU8g7FzbajaXpbmjVYJ"
      ],
      "total_value": "1000",
      "total_value_received": "1000",
      "total_value_sent": "0"
    },

The actual transaction history is https://xrpscan.com/account/rp1Ve83fKy5XbNMkaNmkEbgRp4HJhuKoX3
for 2DF1C6299709D5BB13FF3C298E89FE61A09D3A4B692F93002E36CC26BFF8860B tx_hash. the amount was sent from rp1Ve83fKy5XbNMkaNmkEbgRp4HJhuKoX3 but it is in the received side.

I am seeing this error in many more addresses

@saurabhdaga-merkle
Copy link
Author

is the intended results supposed to only show XRP payments ?

@gnurag
Copy link

gnurag commented Sep 14, 2020

The payments array should include both XRP and IOUs. The payment 049DC2035178864E6D3360A53D2CC8A4B5E17711BD729CE964D63587DDF8AEF4 is infact a 2 EUR.rGJ3MKc1mdQFt1RU8g7FzbajaXpbmjVYJ payment.

@saurabhdaga-merkle
Copy link
Author

the problem is with 2DF1C6299709D5BB13FF3C298E89FE61A09D3A4B692F93002E36CC26BFF8860B tx_hash

@gnurag
Copy link

gnurag commented Sep 16, 2020

Are you referring to the "high_value_received": "1000", and "total_value_received": "1000", properties? That does look like something that should be on the *_value_sent side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants