Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaks and double frees in unsafe code #5

Open
rlei opened this issue Mar 19, 2019 · 3 comments
Open

Leaks and double frees in unsafe code #5

rlei opened this issue Mar 19, 2019 · 3 comments
Assignees
Labels
bug Something isn't working critical Show stopper bug
Milestone

Comments

@rlei
Copy link
Owner

rlei commented Mar 19, 2019

Multiple occurrences of leaks and (possible) double frees caused by unmatched Box::into_raw and Box::from_raw calls have be identified in current implementation.

see 6e6793b for an (incomplete) list of leaks.

@rlei rlei added the bug Something isn't working label Mar 19, 2019
@rlei rlei added this to the 0.1.0-alpha milestone Mar 19, 2019
@rlei rlei self-assigned this Mar 19, 2019
@rlei
Copy link
Owner Author

rlei commented Mar 20, 2019

For example, the summary from
valgrind --leak-check=full target/debug/deps/nonblockinghashmap-69f481c86edb5ffd --nocapture test_hashmap_concurrent_rw_no_resize:
(with num_keys lowered to 10_000 in test)

==28153== LEAK SUMMARY:
==28153==    definitely lost: 4,000,000 bytes in 250,000 blocks
==28153==    indirectly lost: 7,320,000 bytes in 440,000 blocks
==28153==      possibly lost: 0 bytes in 0 blocks
==28153==    still reachable: 32 bytes in 1 blocks
==28153==         suppressed: 0 bytes in 0 blocks
==28153== Reachable blocks (those to which a pointer was found) are not shown.

@rlei
Copy link
Owner Author

rlei commented Mar 28, 2019

Commit 650d798 just kicked off the rewriting of the underlying key/value storage.

@rlei
Copy link
Owner Author

rlei commented Apr 2, 2019

And ed9d9bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Show stopper bug
Projects
None yet
Development

No branches or pull requests

1 participant