feat: add ability for multiple entry paths and postrotate commands #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update template to remove the multitude of unneeded blank lines while maintaining easy to read structure.
With this change, `path` and `postrotate` can additionally be a list of strings (as it is valid with logrotate to supply multiple postrotate commands or file entries). Specifying just a string as it was before is still possible.
|
@tazend it has been a while since you authored this PR. Are you still hoping to have it merged, or have you moved onto a different solution? I'm asking because I've just discovered @robertdebock's role, and I have the same requirement that you did when you raised this change - to be able to specify entry path as a list in addition to being able to specify a single item. If you're not wishing to pursue this any further, I will add the functionality myself in a separate PR, in the hope that it will get merged. Thanks! |
|
@danrough I still hope to have it merged at some point. At the moment I just use the branch of my fork where its implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this branch is based on #8 which fixes the unnecessary blank lines the current template produces.
Describe the change
This branch also adds the ability to specify a list for the
pathandpostrotatevariable, as having multiple paths and postrotate-commands is perfectly fine in logrotate.It is however still possible to simply specify a single string as before (just to not break existing setups) - necessary checks where added in
assert.yml(Fixes #15)Testing
I checked the result produced by the template and it looked fine, both for multiple and single paths/postrotate commands.