Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support google.protobuf.Value #100

Open
shhac opened this issue Jan 30, 2023 · 1 comment
Open

Support google.protobuf.Value #100

shhac opened this issue Jan 30, 2023 · 1 comment

Comments

@shhac
Copy link

shhac commented Jan 30, 2023

I'm working with gRPC, field masks and google.protobuf.Value, and the fact that it is cyclic is making Wombat unusable 😞

It is rare that people use a cyclic structure to depths of more than 4 or 5, so would it be possible to change the error on cyclic types to instead depth count and "snip" when it reaches some reasonable/configured depth (e.g. 7) rather than throwing away the whole graph?

import "google/protobuf/field_mask.proto";
import "google/protobuf/struct.proto";

service ExampleService {
  rpc Example(ExampleRequest) returns (ExampleResponse);
}

message ExampleRequest {
  google.protobuf.FieldMask field_mask = 1;
  google.protobuf.Value data = 2;
}

message ExampleResponse {
  bool success = 1;
}
@shhac
Copy link
Author

shhac commented Jul 11, 2024

I made a PR with the idea around depth 7, but I'm not sure how to actually run go app to confirm this is the behaviour we'd want (go run . resulted in the window opening but blank)

#111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant