Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oxc tranformer #60

Merged
merged 35 commits into from
Oct 11, 2024
Merged

feat: oxc tranformer #60

merged 35 commits into from
Oct 11, 2024

Conversation

underfin
Copy link
Collaborator

@underfin underfin commented Sep 29, 2024

Description

Using oxc transformer instead of esbuild, including dep optimizer and transform plugin at dev/build.

@underfin underfin marked this pull request as draft September 29, 2024 14:31
@underfin
Copy link
Collaborator Author

underfin commented Oct 8, 2024

Meet the character garbled problem, need to figout it.

format_escaped_str_contents ../../playground-temp/worker/modules/test-plugin.js.js�s�)��^�s b�sl�00ض2Q~mport.t
thread '<unnamed>' panicked at /Users/likui/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde_json-1.0.128/src/ser.rs:2082:64:
byte index 58 is not a char boundary; it is inside '\0' (bytes 57..58) of `../../playground-temp/worker/modules/test-plugin.js.js�s�)��^�s b�sl�00ض2Q~mport.t`


// other case
byte index 34 is not a char boundary; it is inside '\u{b}' (bytes 33..34) of `���rL���:*���rL�
                                                                                              �rL���:*��������Pvp."pմk�#�P״k��d�0�״k@0��0�`00|p.`[...]

@sapphi-red sapphi-red force-pushed the rolldown-v6 branch 2 times, most recently from 2f09b9c to 66201d6 Compare October 10, 2024 02:13
@underfin underfin marked this pull request as ready for review October 11, 2024 08:53
@sapphi-red
Copy link

Added some minor changes. Looks good to me!

@sapphi-red sapphi-red merged commit 89d3c22 into rolldown-v6 Oct 11, 2024
8 checks passed
@sapphi-red sapphi-red deleted the oxc-tranformer branch October 11, 2024 11:34
sapphi-red pushed a commit that referenced this pull request Oct 15, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Oct 24, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Oct 24, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Oct 24, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Nov 6, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Nov 13, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Nov 13, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Nov 13, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Nov 14, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Nov 22, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Nov 22, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Nov 29, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Dec 26, 2024
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red pushed a commit that referenced this pull request Jan 9, 2025
Co-authored-by: IWANABETHATGUY <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants