Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: Update peer dependencies for react and react-dom to support ^19.0.0 #397

Open
1 task done
xava-dev opened this issue Jan 3, 2025 · 1 comment
Open
1 task done
Labels

Comments

@xava-dev
Copy link

xava-dev commented Jan 3, 2025

Is there an existing issue or pull request for this?

  • I have searched the existing issues and pull requests

Feature description

Would appreciate if the peer dependencies of react and react-dom could be updated to support the latest released React version ^19.0.0

Desired solution

Peer dependencies of react and react-dom include ^19.0.0

Additional context

No response

@xava-dev xava-dev changed the title request: Update peer dependencies for React and react-dom to support v19 request: Update peer dependencies for react and react-dom to support v19 Jan 3, 2025
@xava-dev xava-dev changed the title request: Update peer dependencies for react and react-dom to support v19 request: Update peer dependencies for react and react-dom to support ^19.0.0 Jan 3, 2025
@favna
Copy link
Collaborator

favna commented Jan 5, 2025

FYI you can disable peer dependency checking in your package manager. If I remember correctly npm never really checked it other than giving a warning, same for pnpm, and yarn only did in v1 and if you're still using yarn v1 then upgrade to v4 already.

Anyway the main reason why I held back the renovate PR to do this is because the tests aren't updated for it yet, that is to say, the project itself should also use React 19 in my opinion. Open to PRs for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants