Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

helper to add reviewers in DESCRIPTION #3

Closed
maelle opened this issue Mar 28, 2018 · 2 comments
Closed

helper to add reviewers in DESCRIPTION #3

maelle opened this issue Mar 28, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@maelle
Copy link
Contributor

maelle commented Mar 28, 2018

  • Have a message reminding the author to ask reviewers for their permissions first.

  • The function would add a comment about the review with an URL based on the issue number.

  • Ideally all reviewers could be added at the same time (and then removed by hand if one said no) via supplying only the onboarding issue number (or nothing, if the function first tries to find the review badge, and errors if there's none). This would mean having

    • A public database of reviewers by issue number

    • A way to deduce a person field from that.

Maybe the 3d point is not worth it and the function could simply return person("first name", "last name", role = c("rev"), comment = "FIRSTNAME LASTNAME reviewed the package for rOpenSci, see https://github.com/ropensci/onboarding/issues/<issue_number>") to the clipboard and tell the author to paste and modify it for each reviewer.

@maelle maelle changed the title helper to add reviewers in DESCRIPTION based on their GH username? helper to add reviewers in DESCRIPTION (based on their GH username?) Mar 28, 2018
@maelle
Copy link
Contributor Author

maelle commented Jun 28, 2018

Linked to ropensci/software-review-meta#49

Once there's such a database this function would just work if there's a peer-review badge in the README.

@maelle maelle changed the title helper to add reviewers in DESCRIPTION (based on their GH username?) helper to add reviewers in DESCRIPTION Jul 2, 2018
@maelle
Copy link
Contributor Author

maelle commented Oct 4, 2018

The desc function I'm adding via r-lib/desc#73 might help but it's limited to having a) full name actually on GitHub b) a full name that's well parsed by as.person() which won't apply to all names.

@maelle maelle added the enhancement New feature or request label May 14, 2019
@maelle maelle closed this as completed Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant