-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests need to fail gracefully without internet #230
Comments
So should the whole test suite be skipped if there's no internet connection? Not very graceful though, we should make the whole package better at working w/o internet. 🤔 |
Cf also #175 |
I modified I used In principle we should overhaul the design to work better in offline mode (i.e. warnings and fall-back methods instead of errors), though in practice that loses a lot of the richness of the current package. A codemeta-lite that worked with minimal dependencies to parse local DESCRIPTION, README, etc would be a more practical offline solution and could eventually be swapped in here to provide the core functionality. but that's a big lift so not sure when it would happen. |
but meanwhile I've gone and released 1.8 with these patches so at least the powers-at-CRAN should be happy for a bit. |
A good number of functions require an internet connection, running the test suite without a connection still goes poorly. CRAN's solaris machines seem particularly good at failing to make successful internet calls and CRAN doesn't like it when this causes the tests to fail...
The text was updated successfully, but these errors were encountered: